linux-kernel - Re: [PATCH] keys/keyring: Fix typo in string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YsuQihEKR8DC+Pnm@kernel.org>
Date:   Mon, 11 Jul 2022 05:52:58 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Li zeming <zeming@...china.com>
Cc:     dhowells@...hat.com, jmorris@...ei.org, serge@...lyn.com,
        keyrings@...r.kernel.org, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...china.com
Subject: Re: [PATCH] keys/keyring: Fix typo in string

On Mon, Jul 04, 2022 at 10:56:10AM +0800, Li zeming wrote:
> Remove the repeated ',' from string
> 
> Signed-off-by: Li zeming <zeming@...china.com>
> ---
>  security/keys/keyring.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/keys/keyring.c b/security/keys/keyring.c
> index 5e6a90760753..c6c47ca9b57d 100644
> --- a/security/keys/keyring.c
> +++ b/security/keys/keyring.c
> @@ -460,7 +460,7 @@ static int keyring_read_iterator(const void *object, void *data)
>  	struct keyring_read_iterator_context *ctx = data;
>  	const struct key *key = keyring_ptr_to_key(object);
>  
> -	kenter("{%s,%d},,{%zu/%zu}",
> +	kenter("{%s,%d},{%zu/%zu}",
>  	       key->type->name, key->serial, ctx->count, ctx->buflen);
>  
>  	if (ctx->count >= ctx->buflen)
> @@ -484,7 +484,7 @@ static long keyring_read(const struct key *keyring,
>  	struct keyring_read_iterator_context ctx;
>  	long ret;
>  
> -	kenter("{%d},,%zu", key_serial(keyring), buflen);
> +	kenter("{%d},%zu", key_serial(keyring), buflen);
>  
>  	if (buflen & (sizeof(key_serial_t) - 1))
>  		return -EINVAL;
> -- 
> 2.18.2
> 

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko