linux-kernel - Re: [PATCH 3/3] ASoC: amd: fix for variable set but not used warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220711025933.3445-1-zhuning0077@gmail.com>
Date:   Mon, 11 Jul 2022 10:59:33 +0800
From:   Zhu Ning <zhuning0077@...il.com>
To:     vijendar.mukunda@....com
Cc:     Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
        alsa-devel@...a-project.org, amadeuszx.slawinski@...ux.intel.com,
        broonie@...nel.org, christophe.jaillet@...adoo.fr,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org, lkp@...el.com,
        tiwai@...e.com, zhuning@...rest-semi.com
Subject: Re: [PATCH 3/3] ASoC: amd: fix for variable set but not used warning

This code is ok. The machine driver should still function well without gpio.

if (IS_ERR(gpio_pa)) {
        gpiod_put(gpio_pa);
        put_device(codec_dev);
        return dev_err_probe(card->dev, PTR_ERR(gpio_pa),
                                            "could not get pa-enable GPIO\n");

}

You donnot need to handle null gpio_pa gpio.

if (!(IS_ERR_OR_NULL(gpio_pa))) 
	gpiod_set_value_cansleep(gpio_pa, true);