linux-kernel - Re: [PATCH v2] tracing/histograms: Fix memory leak problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220712105101.49020368@gandalf.local.home>
Date:   Tue, 12 Jul 2022 10:51:01 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zheng Yejian <zhengyejian1@...wei.com>
Cc:     <linux-kernel@...r.kernel.org>, <mingo@...hat.com>,
        <stable@...r.kernel.org>, <tom.zanussi@...ux.intel.com>,
        <trix@...hat.com>, <zhangjinhao2@...wei.com>
Subject: Re: [PATCH v2] tracing/histograms: Fix memory leak problem

On Tue, 12 Jul 2022 19:48:44 +0800
Zheng Yejian <zhengyejian1@...wei.com> wrote:

> Since I'm not very familiar with trace_events_hist.c, I roughly conclude that:
>   1. warning 1/3/6 are plausible but false-positive;
>   2. warning 2/4/5 seems positive although they don't cause practical problems because
> elt_data->field_var_str[i] / ref_field->system / ref_field->name can be 'NULL'
> on 'kfree'. Do we need to explicitly check 'NULL' there?

It's confusing code. Both Tom and I missed it as well.

-- Steve