linux-kernel - Re: [PATCH v4 1/2] sched/rt: fix bad task migration for rt tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2sfn7glkk.fsf@gmail.com>
Date:   Tue, 12 Jul 2022 09:33:58 +0800
From:   Schspa Shi <schspa@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com,
        vschneid@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] sched/rt: fix bad task migration for rt tasks


Steven Rostedt <rostedt@...dmis.org> writes:

> On Tue, 12 Jul 2022 08:53:56 +0800
> Schspa Shi <schspa@...il.com> wrote:
>
>> How about to change this to 
>> 
>> 			/*
>> 			 * We had to unlock the run queue. In
>> 			 * the mean time, task could have
>> 			 * migrated already or had its affinity changed.
>> 			 * Also make sure that it wasn't scheduled on its rq.
>> 			 * It is possible the task was scheduled, set
>>              * "migrate_disabled" and then got preempted, And we
>>              * check task migration disable flag here too.
>> 			 */
>
> That's better. But of course it needs better formatting ;-)
>
> -- Steve

I have upload a v5 patch for this comment change, please review it. ;-)
Link: https://lore.kernel.org/all/20220712013125.623338-1-schspa@gmail.com/T/#t

-- 
BRs
Schspa Shi