linux-kernel - Re: [PATCH v4] dt-bindings: qcom: document preferred compatible naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220712165715.GD1823936-robh@kernel.org>
Date:   Tue, 12 Jul 2022 10:57:15 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Andy Gross <agross@...nel.org>, devicetree@...r.kernel.org,
        Robert Foss <robert.foss@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Alex Elder <elder@...aro.org>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        linux-kernel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
Subject: Re: [PATCH v4] dt-bindings: qcom: document preferred compatible
 naming

On Wed, Jul 06, 2022 at 08:55:18AM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2022 21:18, Rob Herring wrote:
> > On Tue, 05 Jul 2022 18:13:01 +0200, Krzysztof Kozlowski wrote:
> >> Compatibles can come in two formats.  Either "vendor,ip-soc" or
> >> "vendor,soc-ip".  Qualcomm bindings were mixing both of usages, so add a
> >> DT schema file documenting preferred policy and enforcing it for all new
> >> compatibles, except few existing patterns.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>
> >> ---
> >>
> >> Changes since v3:
> >> 1. Add qcom,kpss-wdt-xxx to pattern for exceptions.
> >> 2. Add ipq806x entries to list of exceptions.
> >>
> >> Changes since v2:
> >> 1. Narrow the expected pattern to be followed by dash '-' after model
> >>    number (msm8996-) or by two letters and a dash (sc8280xp-).
> >> 2. Add qcom,apss-wdt-xxx to list of exceptions.
> >> 3. Use comment instead of description in the oneOf list.
> >>
> >> Changes since v1:
> >> 1. Add schema instead of readme (Rob).
> >>
> >> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> >> Cc: Vinod Koul <vkoul@...nel.org>
> >> Cc: Alex Elder <elder@...aro.org>
> >> Cc: Robert Foss <robert.foss@...aro.org>
> >> Cc: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> >> ---
> >>  .../devicetree/bindings/arm/qcom-soc.yaml     | 63 +++++++++++++++++++
> >>  1 file changed, 63 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/arm/qcom-soc.yaml
> >>
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.example.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed:
> > 	'qcom,qcs404' does not match '^qcom,(apq|ipq|mdm|msm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$'
> > 	'qcom,qcs404' does not match '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'
> > 	'qcom,qcs404' does not match '^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$'
> > 	'qcom,qcs404' does not match '^qcom,gcc-(apq|ipq|mdm|msm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$'
> > 	'qcom,qcs404' does not match '^qcom,mmcc-(apq|ipq|mdm|msm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$'
> > 	'qcom,qcs404' does not match '^qcom,pcie-(apq|ipq|mdm|msm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$'
> > 	'qcom,qcs404' does not match '^qcom,rpm-(apq|ipq|mdm|msm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$'
> > 	'qcom,qcs404' does not match '^qcom,scm-(apq|ipq|mdm|msm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$'
> > 	'qcom,qcs404' is not one of ['qcom,gpucc-sdm630', 'qcom,gpucc-sdm660', 'qcom,lcc-apq8064', 'qcom,lcc-ipq8064', 'qcom,lcc-mdm9615', 'qcom,lcc-msm8960', 'qcom,lpass-cpu-apq8016', 'qcom,usb-ss-ipq4019-phy', 'qcom,usb-hs-ipq4019-phy', 'qcom,vqmmc-ipq4019-regulator']
> > 	'qcom,qcs404' is not one of ['qcom,ipq806x-nand', 'qcom,ipq806x-usb-phy-ss', 'qcom,ipq806x-usb-phy-hs']
> > 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > 
> 
> This is fixed by:
> https://lore.kernel.org/all/20220627143340.477120-1-krzysztof.kozlowski@linaro.org/
> https://lore.kernel.org/all/20220628092253.21905-1-krzysztof.kozlowski@linaro.org/

Okay, as long as those are applied together:

Reviewed-by: Rob Herring <robh@...nel.org>