linux-kernel - Re: [sj:damon/next 20/20] drivers/block/xen-blkback/xenbus.c:184:38: error: use of undeclared identifier 'feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220712171306.75486-1-sj@kernel.org>
Date:   Tue, 12 Jul 2022 17:13:06 +0000
From:   SeongJae Park <sj@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     SeongJae Park <sj@...nel.org>, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [sj:damon/next 20/20] drivers/block/xen-blkback/xenbus.c:184:38: error: use of undeclared identifier 'feature_persistent'

On Tue, 12 Jul 2022 14:22:23 +0800 kernel test robot <lkp@...el.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   40d1ef717dd762939c0a8734fd901ee517b50334
> commit: 40d1ef717dd762939c0a8734fd901ee517b50334 [20/20] xen-blkback: fix persistent grants negotiation
> config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220712/202207121401.8Yis7IHm-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project badda4ac3c489a8c8cccdad1f74b9308c350a9e0)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?id=40d1ef717dd762939c0a8734fd901ee517b50334
>         git remote add sj https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git
>         git fetch --no-tags sj damon/next
>         git checkout 40d1ef717dd762939c0a8734fd901ee517b50334
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/block/xen-blkback/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/block/xen-blkback/xenbus.c:184:38: error: use of undeclared identifier 'feature_persistent'
>            blkif->vbd.feature_gnt_persistent = feature_persistent;
>                                                ^
>    1 error generated.

Thank you for the report.  I fixed it as below and pushed:

    +/* Enable the persistent grants feature. */
    +static bool feature_persistent = true;
    +module_param(feature_persistent, bool, 0644);
    +MODULE_PARM_DESC(feature_persistent, "Enables the persistent grants feature");
    +
     static struct xen_blkif *xen_blkif_alloc(domid_t domid)
     {
            struct xen_blkif *blkif;
    @@ -474,12 +479,6 @@ static void xen_vbd_free(struct xen_vbd *vbd)
            vbd->bdev = NULL;
     }
    
    -/* Enable the persistent grants feature. */
    -static bool feature_persistent = true;
    -module_param(feature_persistent, bool, 0644);
    -MODULE_PARM_DESC(feature_persistent,
    -               "Enables the persistent grants feature");
    -
     static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
                              unsigned major, unsigned minor, int readonly,
                              int cdrom)

Note: The commit is only for my personal test at the moment.

[...]