linux-kernel - Re: [PATCH] mm/compaction: fix set skip in fast_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jul 2022 10:26:47 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Zhou Chuyi <zhouchuyi@...edance.com>, <linux-mm@...ck.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/compaction: fix set skip in fast_find_migrateblock

Add Cc Andrew and linux-kernel email list.

On 2022/7/11 20:32, Zhou Chuyi wrote:
> From: zhouchuyi <zhouchuyi@...edance.com>
> 
> When we successfully find a pageblock in fast_find_migrateblock(), the block will be set skip-flag through set_pageblock_skip(). However, when entering isolate_migratepages_block(), the whole pageblock will be skipped due to the branch 'if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages))'. Eventually we will goto isolate_abort and isolate nothing.
> Signed-off-by: zhouchuyi <zhouchuyi@...edance.com>

It seems we should tweak the commit log to satisfy the checkpatch.pl first.

> ---
>  mm/compaction.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 1f89b969c..a1a2b50c8 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1852,7 +1852,6 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc)
>  					pfn = cc->zone->zone_start_pfn;
>  				cc->fast_search_fail = 0;
>  				found_block = true;
> -				set_pageblock_skip(freepage);

This looks like a real problem. Should we add a Fixes tag here? What's the runtime effect of it?

Thanks for your patch!

>  				break;
>  			}
>  		}
>