linux-kernel - Re: [PATCH] PCI/ASPM: Unexport pcie_aspm_support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Jul 2022 14:36:08 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Linux PCI <linux-pci@...r.kernel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()

On Tue, Jul 12, 2022 at 08:10:03PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jul 12, 2022 at 1:14 AM Bjorn Helgaas <helgaas@...nel.org> wrote:
> >
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> >
> > pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver,
> > which cannot be built as a module, so it does not need to be exported.
> > Unexport it.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Thanks, applied with your Reviewed-by to pci/aspm for v5.20.

> > ---
> >  drivers/pci/pcie/aspm.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> > index 7f76a5875feb..a8aec190986c 100644
> > --- a/drivers/pci/pcie/aspm.c
> > +++ b/drivers/pci/pcie/aspm.c
> > @@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
> >  {
> >         return aspm_support_enabled;
> >  }
> > -EXPORT_SYMBOL(pcie_aspm_support_enabled);
> > --
> > 2.25.1
> >