linux-kernel - Re: [PATCH V2] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db31ded1-d240-e5a0-c4ec-03ad7aef6af8@linaro.org>
Date:   Tue, 12 Jul 2022 23:02:46 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Satya Priya <quic_c_skakit@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Taniya Das <tdas@...eaurora.org>, mka@...omium.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Taniya Das <quic_tdas@...cinc.com>
Subject: Re: [PATCH V2] arm64: dts: qcom: sc7280: Update lpassaudio clock
 controller for resets

On 07/07/2022 10:15, Satya Priya wrote:
> From: Taniya Das <quic_tdas@...cinc.com>
> 
> The lpass audio supports TX/RX/WSA block resets. Disable the LPASS PIL
> clock by default, boards can enable it if needed.

You made here few different changes at once but I fail to see why. The
most important message in commit msg is "why?". Why are you disabling
LPASS PIL by default?

> 
> Also to keep consistency update lpasscore to lpass_core.

This definitely should not be backported to stable.

> 
> Fixes: 9499240d15f2 ("arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers")

This does not look right or I did not understand where the bug is.
Please describe what is the error/issue/bug being fixed (which would
explain the need of backporting).

More over, the patch alone brings regression - disables the LPASS PIL
while before it was enabled. For sure it should not be backported.

> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
> Signed-off-by: Satya Priya <quic_c_skakit@...cinc.com>
> ---
> Changes since V1:
>  - Updated the phandle reference in lpass_aon node.
>  - As per Matthias' comment updated the commit text.
> 
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)


Best regards,
Krzysztof