[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Ys3uDJ90dBeFFbka@xz-m1.local>
Date: Tue, 12 Jul 2022 17:56:28 -0400
From: Peter Xu <peterx@...hat.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
Wanpeng Li <wanpengli@...cent.com>,
Jim Mattson <jmattson@...gle.com>,
Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] KVM: x86/mmu: Defer "full" MMU setup until after
vendor hardware_setup()
On Fri, Jun 24, 2022 at 11:27:33PM +0000, Sean Christopherson wrote:
> @@ -11937,6 +11932,10 @@ int kvm_arch_hardware_setup(void *opaque)
>
> kvm_ops_update(ops);
>
> + r = kvm_mmu_hardware_setup();
> + if (r)
> + goto out_unsetup;
> +
> kvm_register_perf_callbacks(ops->handle_intel_pt_intr);
>
> if (!kvm_cpu_cap_has(X86_FEATURE_XSAVES))
> @@ -11960,12 +11959,18 @@ int kvm_arch_hardware_setup(void *opaque)
> kvm_caps.default_tsc_scaling_ratio = 1ULL << kvm_caps.tsc_scaling_ratio_frac_bits;
> kvm_init_msr_list();
> return 0;
> +
> +out_unsetup:
> + static_call(kvm_x86_hardware_unsetup)();
Should this be kvm_mmu_hardware_unsetup()? Or did I miss something?..
--
Peter Xu
Powered by blists - more mailing lists