[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BL0PR12MB25796644B683AB6FAF6BD9D6E4869@BL0PR12MB2579.namprd12.prod.outlook.com>
Date: Tue, 12 Jul 2022 07:36:01 +0000
From: "Agarwal, Swati" <swati.agarwal@....com>
To: Vinod Koul <vkoul@...nel.org>,
Swati Agarwal <swati.agarwal@...inx.com>
CC: "lars@...afoo.de" <lars@...afoo.de>,
"adrianml@...mnos.upm.es" <adrianml@...mnos.upm.es>,
"libaokun1@...wei.com" <libaokun1@...wei.com>,
"marex@...x.de" <marex@...x.de>,
"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"harini.katakam@...inx.com" <harini.katakam@...inx.com>,
"radhey.shyam.pandey@...inx.com" <radhey.shyam.pandey@...inx.com>,
"michal.simek@...inx.com" <michal.simek@...inx.com>,
"Agarwal, Swati" <swati.agarwal@....com>,
"Katakam, Harini" <harini.katakam@....com>,
"Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
"Simek, Michal" <michal.simek@....com>
Subject: RE: [PATCH 1/2] dmaengine: xilinx_dma: Fix probe error cleanup
Hi Vinod,
> -----Original Message-----
> From: Vinod Koul <vkoul@...nel.org>
> Sent: Friday, July 1, 2022 5:21 PM
> To: Swati Agarwal <swati.agarwal@...inx.com>
> Cc: lars@...afoo.de; adrianml@...mnos.upm.es; libaokun1@...wei.com;
> marex@...x.de; dmaengine@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> harini.katakam@...inx.com; radhey.shyam.pandey@...inx.com;
> michal.simek@...inx.com
> Subject: Re: [PATCH 1/2] dmaengine: xilinx_dma: Fix probe error cleanup
>
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
>
>
> On 24-06-22, 12:05, Swati Agarwal wrote:
> > When probe fails remove dma channel resources and disable clocks in
> > accordance with the order of resources allocated .
>
> Ok this looks fine and the changes below..
Thanks for the review!!
Sorry for the delayed reply. I missed this mail due to some mailer issues.
> >
> > Add missing cleanup in devm_platform_ioremap_resource(),
> > xlnx,num-fstores property.
>
> Where is this part?
The statement is an elaboration of the previous one. The relevant code is below.
<snip>
> > /* Request and map I/O memory */
> > xdev->regs = devm_platform_ioremap_resource(pdev, 0);
> > - if (IS_ERR(xdev->regs))
> > - return PTR_ERR(xdev->regs);
> > + if (IS_ERR(xdev->regs)) {
> > + err = PTR_ERR(xdev->regs);
> > + goto disable_clks;
> > + }
This
<snip>
> > if (err < 0) {
> > dev_err(xdev->dev,
> > "missing xlnx,num-fstores property\n");
> > - return err;
> > + goto disable_clks;
> > }
And this
Regards,
Swati Agarwal
Powered by blists - more mailing lists