linux-kernel - Re: [PATCH] time: remove useless "const" keyword in ns_to_kernel_old_timeval() and ns_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0pCov7ZiNhG+by7PpxMdBbBpUa7TKNc9e0p-zXvqg-7g@mail.gmail.com>
Date:   Tue, 12 Jul 2022 09:41:43 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Youngmin Nam <youngmin.nam@...sung.com>
Cc:     Arnd Bergmann <arnd@...db.de>, John Stultz <jstultz@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Chanho Park <chanho61.park@...sung.com>,
        hajun.sung@...sung.com, hosung0.kim@...sung.com,
        d7271.choe@...sung.com
Subject: Re: [PATCH] time: remove useless "const" keyword in
 ns_to_kernel_old_timeval() and ns_to_timespec64()

On Tue, Jul 12, 2022 at 9:47 AM Youngmin Nam <youngmin.nam@...sung.com> wrote:
>
> As mentioned below,
> https://lore.kernel.org/lkml/CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5BbesdvMBgA@mail.gmail.com/
>
> The "const" keyword is useless, so we drop it from the function definition and declaration.
>
> Change-Id: If35bba78aa7757476e22be42afc719c27fb0f527
> Signed-off-by: Youngmin Nam <youngmin.nam@...sung.com>

The patch looks good, but the description can be improved:

- drop the useless Change-Id field
- move the URL into a 'Link: field'
- wrap the lines to fit into the normal width of an email (under 80 characters,
  ideally 70)
- explain why the change helps, rather than just stating the keyword is useless.
  In your description, it's not clear if one is better than the other, it sounds
  like it should make no difference.

With that done:

Reviewed-by: Arnd Bergmann <arnd@...db.de>