linux-kernel - Re: [PATCH v2 2/3] pinctrl: sunxi: add support for R329 CPUX pin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a947683de71e68a0925cfd4cab80238c3a03205.camel@icenowy.me>
Date:   Tue, 12 Jul 2022 17:37:14 +0800
From:   Icenowy Zheng <uwu@...nowy.me>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Maxime Ripard <mripard@...nel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        linux-sunxi@...ts.linux.dev,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Maxime Ripard <maxime@...no.tech>
Subject: Re: [PATCH v2 2/3] pinctrl: sunxi: add support for R329 CPUX pin
 controller

在 2022-07-10星期日的 21:06 +0200，Andy Shevchenko写道：
> On Sun, Jul 10, 2022 at 10:22 AM Icenowy Zheng <uwu@...nowy.me>
> wrote:
> > 
> > Allwinner R329 SoC has two pin controllers similar to ones on
> > previous
> > SoCs, one in CPUX power domain and another in CPUS.
> > 
> > This patch adds support for the CPUX domain pin controller.
> 
> ...
> 
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
> 
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> 
> No use of these.
> 
> > +#include <linux/pinctrl/pinctrl.h>
> 
> Missed headers:
> mod_devicetable.h

Thanks for these.

In addition, how to decide what header should be included? The code
works properly because of_device.h includes mod_devicetable.h.

> 
> > +#include "pinctrl-sunxi.h"
>