linux-kernel - Re: [PATCH 2/3] arm64: dts: meson: add S4 Soc clock controller in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5b3e2de-ec60-88ee-4066-6b3860b6c89a@linaro.org>
Date:   Tue, 12 Jul 2022 11:41:54 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Yu Tu <yu.tu@...ogic.com>, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH 2/3] arm64: dts: meson: add S4 Soc clock controller in DT

On 08/07/2022 08:27, Yu Tu wrote:
> Added information about the S4 SOC Clock controller in DT.
> 
> Signed-off-by: Yu Tu <yu.tu@...ogic.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index ff213618a598..ad2ec26a1f4a 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -86,7 +86,7 @@ gic: interrupt-controller@...01000 {
>  		};
>  
>  		apb4: apb4@...00000 {
> -			compatible = "simple-bus";
> +			compatible = "simple-bus", "syscon";

This is not allowed.
1. syscon needs also dedicated compatible
2. simple-bus with syscon means it is not a simple bus anymore, so nope.

>  			reg = <0x0 0xfe000000 0x0 0x480000>;
>  			#address-cells = <2>;
>  			#size-cells = <2>;
> @@ -118,6 +118,13 @@ gpio_intc: interrupt-controller@...0 {
>  					<10 11 12 13 14 15 16 17 18 19 20 21>;
>  			};
>  
> +			clkc: clock-controller {
> +				compatible = "amlogic,s4-clkc";
> +				#clock-cells = <1>;
> +				clocks = <&xtal>;
> +				clock-names = "xtal";
> +			};
> +
>  			uart_B: serial@...00 {
>  				compatible = "amlogic,meson-s4-uart",
>  					     "amlogic,meson-ao-uart";


Best regards,
Krzysztof