linux-kernel - Re: [PATCH 1/2] perf test: Add debug line to diagnose broken metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ys1gBdoqy2W51Rt+@kernel.org>
Date:   Tue, 12 Jul 2022 08:50:29 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        John Garry <john.garry@...wei.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 1/2] perf test: Add debug line to diagnose broken metrics

Em Thu, Jul 07, 2022 at 08:34:48AM -0700, Ian Rogers escreveu:
> Printing out the metric name and architecture makes finding the source
> of a failure easier.

Thanks, applied both patches.

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/tests/pmu-events.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/pmu-events.c b/tools/perf/tests/pmu-events.c
> index f13368569d8b..478b33825790 100644
> --- a/tools/perf/tests/pmu-events.c
> +++ b/tools/perf/tests/pmu-events.c
> @@ -1115,6 +1115,7 @@ static int test__parsing_fake(struct test_suite *test __maybe_unused,
>  				break;
>  			if (!pe->metric_expr)
>  				continue;
> +			pr_debug("Found metric '%s' for '%s'\n", pe->metric_name, map->cpuid);
>  			err = metric_parse_fake(pe->metric_expr);
>  			if (err)
>  				return err;
> -- 
> 2.37.0.rc0.161.g10f37bed90-goog

-- 

- Arnaldo