linux-kernel - Re: [PATCH -V2 1/7] migrate: fix syscall move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zghf5eov.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Tue, 12 Jul 2022 08:59:12 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     Oscar Salvador <osalvador@...e.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Zi Yan <ziy@...dia.com>, Yang Shi <shy828301@...il.com>
Subject: Re: [PATCH -V2 1/7] migrate: fix syscall move_pages() return value
 for failure

Oscar Salvador <osalvador@...e.de> writes:

> On Mon, Jul 11, 2022 at 04:49:42PM +0800, Huang Ying wrote:
>>  	return store_status(status, start, node, i - start);
>> @@ -1768,8 +1768,12 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>>  
>>  		err = move_pages_and_store_status(mm, current_node, &pagelist,
>>  				status, start, i, nr_pages);
>> -		if (err)
>> +		if (err) {
>> +			/* We have stored status of page i */
>
> IMHO, "We have accounted for page i" gives a more clear statement.

Sure.  Will change this.

> Reviewed-by: Oscar Salvador <osalvador@...e.de>

Thanks!

Best Regards,
Huang, Ying

>> +			if (err > 0)
>> +				err--;
>>  			goto out;
>> +		}
>>  		current_node = NUMA_NO_NODE;
>>  	}
>>  out_flush:
>> -- 
>> 2.30.2
>> 
>>