linux-kernel - [PATCH 7/7] venus : Allow MIN/MAX settings for the v4l2 encoder controls defined range .

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220712122347.6781-7-quic_vboma@quicinc.com>
Date:   Tue, 12 Jul 2022 17:53:47 +0530
From:   Viswanath Boma <quic_vboma@...cinc.com>
To:     video.upstream.external@....qualcomm.com,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Vikash Garodia <quic_vgarodia@...cinc.com>,
        Viswanath Boma <quic_vboma@...cinc.com>
Subject: [PATCH 7/7] venus : Allow MIN/MAX settings for the v4l2 encoder controls defined range  .

From: Vikash Garodia <quic_vgarodia@...cinc.com>

 Control MIN/MAX range defined as 0 to 1 ,as MIN value setting enabled
 for V4L2_CID_MPEG_VIDEO_H264_8X8_TRANSFORM .

 error details: fail: v4l2-test-controls.cpp(516): invalid maximum range check

Change-Id: I8db2585d35a72bf238cec4cd8f49661170e98a85
Signed-off-by: Viswanath Boma <quic_vboma@...cinc.com>
---
 drivers/media/platform/qcom/venus/venc_ctrls.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c b/drivers/media/platform/qcom/venus/venc_ctrls.c
index 95fdad160732b..6dcbd3baa9c86 100644
--- a/drivers/media/platform/qcom/venus/venc_ctrls.c
+++ b/drivers/media/platform/qcom/venus/venc_ctrls.c
@@ -323,19 +323,6 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl)
 		if (ctr->profile.h264 != V4L2_MPEG_VIDEO_H264_PROFILE_HIGH &&
 		    ctr->profile.h264 != V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_HIGH)
 			return -EINVAL;
-
-		/*
-		 * In video firmware, 8x8 transform is supported only for
-		 * high profile(HP) and constrained high profile(CHP).
-		 * If client wants to disable 8x8 transform for HP/CHP,
-		 * it is better to set profile as main profile(MP).
-		 * Because there is no difference between HP and MP
-		 * if we disable 8x8 transform for HP.
-		 */
-
-		if (ctrl->val == 0)
-			return -EINVAL;
-
 		ctr->h264_8x8_transform = ctrl->val;
 		break;
 	default:
-- 
2.17.1