linux-kernel - Re: [PATCH 4/5] ARM: stacktrace: Make stack walk callback consistent with generic code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ys14cMm0n6EqS/cQ@sirena.org.uk>
Date:   Tue, 12 Jul 2022 14:34:40 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Li Huafei <lihuafei1@...wei.com>
Cc:     linux@...linux.org.uk, rmk+kernel@...linux.org.uk, ardb@...nel.org,
        will@...nel.org, mark.rutland@....com, peterz@...radead.org,
        mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        namhyung@...nel.org, arnd@...db.de, linus.walleij@...aro.org,
        rostedt@...dmis.org, nick.hawkins@....com, john@...ozen.org,
        mhiramat@...nel.org, ast@...nel.org, linyujun809@...wei.com,
        ndesaulniers@...gle.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 4/5] ARM: stacktrace: Make stack walk callback consistent
 with generic code

On Tue, Jul 12, 2022 at 10:15:26AM +0800, Li Huafei wrote:

> In order to use generic arch_stack_walk() code, make stack walk callback
> consistent with it.

It might be useful to say what the changes are here, if nothing else
that makes it easier to review and confirm that the changes are doing
what you intend them to.  See my conversion for arm64 for an example.
The actual changes here seem OK though

Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)