linux-kernel - Re: [PATCH v5 1/2] sched/rt: fix bad task migration for rt tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220712095325.408d1730@gandalf.local.home>
Date:   Tue, 12 Jul 2022 09:53:25 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Schspa Shi <schspa@...il.com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com,
        vschneid@...hat.com, linux-kernel@...r.kernel.org,
        zhaohui.shi@...izon.ai
Subject: Re: [PATCH v5 1/2] sched/rt: fix bad task migration for rt tasks

On Tue, 12 Jul 2022 09:31:24 +0800
Schspa Shi <schspa@...il.com> wrote:

> @@ -1998,11 +1998,15 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task, struct rq *rq)
>  			 * the mean time, task could have
>  			 * migrated already or had its affinity changed.
>  			 * Also make sure that it wasn't scheduled on its rq.
> +			 * It is possible the task was scheduled, set
> +			 * "migrate_disabled" and then got preempted, And we
> +			 * check task migration disable flag here too.

Nit.  "got preempted, so we must check the task migration disable flag here
too".

But other than that.

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

>  			 */