linux-kernel - Re: [RFC PATCH v2 1/1] bpftool: Align dumped file headers with skeletons.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5839621.lOV4Wx5bFT@pwmachine>
Date:   Wed, 13 Jul 2022 16:44:10 +0200
From:   Francis Laniel <flaniel@...ux.microsoft.com>
To:     bpf@...r.kernel.org, Quentin Monnet <quentin@...valent.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2 1/1] bpftool: Align dumped file headers with skeletons.

Le mercredi 13 juillet 2022, 15:57:13 CEST Quentin Monnet a écrit :
> On 13/07/2022 14:40, Francis Laniel wrote:
> > This commit adds the following lines to file generated by dump:
> > /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
> > /* THIS FILE IS AUTOGENERATED BY BPFTOOL! */
> > Hence, the dumped file headers follows that of skeletons.
> > 
> > Signed-off-by: Francis Laniel <flaniel@...ux.microsoft.com>
> > ---
> > 
> >  tools/bpf/bpftool/btf.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
> > index 7e6accb9d9f7..066a0acd0ecd 100644
> > --- a/tools/bpf/bpftool/btf.c
> > +++ b/tools/bpf/bpftool/btf.c
> > @@ -425,6 +425,8 @@ static int dump_btf_c(const struct btf *btf,
> > 
> >  	if (err)
> >  	
> >  		return err;
> > 
> > +	printf("/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */\n");
> > +	printf("/* THIS FILE IS AUTOGENERATED BY BPFTOOL! */\n");
> > 
> >  	printf("#ifndef __VMLINUX_H__\n");
> >  	printf("#define __VMLINUX_H__\n");
> >  	printf("\n");
> 
> Looks good, simpler than v1, thank you!
> 
> Reviewed-by: Quentin Monnet <quentin@...valent.com>

Thank you for the review!