linux-kernel - Re: [PATCH] soundwire: qcom: Update error prints to debug prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75404573094d1c46172fcd51dad6a4e564da1542.camel@perches.com>
Date:   Wed, 13 Jul 2022 09:01:16 -0700
From:   Joe Perches <joe@...ches.com>
To:     Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        vkoul@...nel.org, agross@...nel.org, bjorn.andersson@...aro.org,
        lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        quic_plai@...cinc.com, bgoswami@...cinc.com, perex@...ex.cz,
        tiwai@...e.com, srinivas.kandagatla@...aro.org,
        quic_rohkumar@...cinc.com, linux-arm-msm@...r.kernel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, swboyd@...omium.org,
        judyhsiao@...omium.org
Subject: Re: [PATCH] soundwire: qcom: Update error prints to debug prints

On Wed, 2022-07-13 at 20:22 +0530, Srinivasa Rao Mandadapu wrote:
> On 7/13/2022 7:53 PM, Pierre-Louis Bossart wrote:
> Thanks for your time Pierre-Louis!!!
> > 
> > On 7/13/22 07:22, Srinivasa Rao Mandadapu wrote:
> > > Upadte error prints to debug prints to avoid redundant logging in kernel
> > update
[]
> > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
[]
> > > @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
> > >   				break;
> > >   			case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
> > >   			case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
> > > -				dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
> > > -					__func__);
> > > +				dev_dbg(swrm->dev, "%s: SWR new slave attached\n", __func__);

Could also drop the "%s: ", __func__ as it's already a unique message
and dynamic debug could add it back if really desired.