linux-kernel - Re: [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56f0c3a4-74cd-098a-7bdb-88480be366c2@microchip.com>
Date:   Wed, 13 Jul 2022 16:04:39 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <sudeep.holla@....com>, <linux-kernel@...r.kernel.org>
CC:     <gregkh@...uxfoundation.org>, <vincent.guittot@...aro.org>,
        <dietmar.eggemann@....com>, <ionela.voinescu@....com>,
        <pierre.gondois@....com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH -next] arch_topology: Fix cache attributes detection in
 the CPU hotplug path

On 13/07/2022 14:33, Sudeep Holla wrote:
> Hi Conor,
> 
> Ionela reported an issue with the CPU hotplug and as a fix I need to
> move the call to detect_cache_attributes() which I had thought to keep
> it there from first but for no reason had moved it to init_cpu_topology().
> 
> Wonder if this fixes the -ENOMEM on RISC-V as this one is called on the
> cpu in the secondary CPUs init path while init_cpu_topology executed
> detect_cache_attributes() for all possible CPUs much earlier. I think
> this might help as the percpu memory might be initialised in this case.
> 
> Anyways give this a try, also test the CPU hotplug and check if nothing
> is broken on RISC-V. We noticed this bug only on one platform while

Coll, will give it a go tomorrow probably. I have a swiotlb issue that's
broken my boot to find first :/