linux-kernel - Re: [PATCH v2] iio: light: cm32181: Add PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220713174009.2f18b0e4@jic23-huawei>
Date:   Wed, 13 Jul 2022 17:40:09 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     ktsai@...ellamicro.com, lars@...afoo.de, hdegoede@...hat.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: light: cm32181: Add PM support

On Wed, 13 Jul 2022 09:30:52 +0800
Kai-Heng Feng <kai.heng.feng@...onical.com> wrote:

> On Fri, Jul 8, 2022 at 12:40 AM Jonathan Cameron <jic23@...nel.org> wrote:
> >
> > On Thu,  7 Jul 2022 08:01:51 +0800
> > Kai-Heng Feng <kai.heng.feng@...onical.com> wrote:
> >  
> > > The read on in_illuminance_input keeps at 0 after system sleep.
> > >
> > > So add proper suspend and resume callback to make the sensor keep
> > > working after system sleep.
> > >
> > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>  
> > Applied to the togreg branch of iio.git and pushed out as testing for
> > the autobuilders to poke at it and see if we missed anything,  
> 
> This commit doesn't seem to be included in iio/togreg branch.

Seems I got distracted and didn't push out.
Should be there now,

Jonathan

> Kai-Heng
> 
> >
> > Thanks,
> >
> > Jonathan
> >  
> > > ---
> > > v2:
> > >  - Use dev_get_drvdata() instead of i2c_get_clientdata() to avoid extra
> > >    dereference.
> > >
> > >  drivers/iio/light/cm32181.c | 22 ++++++++++++++++++++++
> > >  1 file changed, 22 insertions(+)
> > >
> > > diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> > > index 97649944f1df6..edbe6a3138d0b 100644
> > > --- a/drivers/iio/light/cm32181.c
> > > +++ b/drivers/iio/light/cm32181.c
> > > @@ -460,6 +460,8 @@ static int cm32181_probe(struct i2c_client *client)
> > >                       return PTR_ERR(client);
> > >       }
> > >
> > > +     i2c_set_clientdata(client, indio_dev);
> > > +
> > >       cm32181 = iio_priv(indio_dev);
> > >       cm32181->client = client;
> > >       cm32181->dev = dev;
> > > @@ -486,6 +488,25 @@ static int cm32181_probe(struct i2c_client *client)
> > >       return 0;
> > >  }
> > >
> > > +static int cm32181_suspend(struct device *dev)
> > > +{
> > > +     struct i2c_client *client = to_i2c_client(dev);
> > > +
> > > +     return i2c_smbus_write_word_data(client, CM32181_REG_ADDR_CMD,
> > > +                                      CM32181_CMD_ALS_DISABLE);
> > > +}
> > > +
> > > +static int cm32181_resume(struct device *dev)
> > > +{
> > > +     struct i2c_client *client = to_i2c_client(dev);
> > > +     struct cm32181_chip *cm32181 = iio_priv(dev_get_drvdata(dev));
> > > +
> > > +     return i2c_smbus_write_word_data(client, CM32181_REG_ADDR_CMD,
> > > +                                      cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
> > > +}
> > > +
> > > +DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
> > > +
> > >  static const struct of_device_id cm32181_of_match[] = {
> > >       { .compatible = "capella,cm3218" },
> > >       { .compatible = "capella,cm32181" },
> > > @@ -506,6 +527,7 @@ static struct i2c_driver cm32181_driver = {
> > >               .name   = "cm32181",
> > >               .acpi_match_table = ACPI_PTR(cm32181_acpi_match),
> > >               .of_match_table = cm32181_of_match,
> > > +             .pm = pm_sleep_ptr(&cm32181_pm_ops),
> > >       },
> > >       .probe_new      = cm32181_probe,
> > >  };  
> >