linux-kernel - Re: [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b11eac7-cabe-a0bc-061f-7b9936c3696f@gmail.com>
Date:   Wed, 13 Jul 2022 09:35:23 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        William Zhang <william.zhang@...adcom.com>,
        Linux ARM List <linux-arm-kernel@...ts.infradead.org>
Cc:     Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        joel.peshkin@...adcom.com, dan.beygelman@...adcom.com,
        kursad.oney@...adcom.com, f.fainelli@...il.com,
        anand.gore@...adcom.com, Arnd Bergmann <arnd@...db.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, soc@...nel.org
Subject: Re: [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to
 ARCH_BCMBCA

On 7/13/22 08:26, Rafał Miłecki wrote:
> On 7.07.2022 09:00, William Zhang wrote:
>> Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
>> CONFIG_ARCH_BCM_63XX from the makefile
>>
>> Signed-off-by: William Zhang <william.zhang@...adcom.com>
>> ---
>>
>> (no changes since v1)
>>
>>   arch/arm/boot/dts/Makefile | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 38d9c60aece7..1bf8e2f8ee68 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -147,8 +147,6 @@ dtb-$(CONFIG_ARCH_BCM_53573) += \
>>       bcm47189-luxul-xap-810.dtb \
>>       bcm47189-tenda-ac9.dtb \
>>       bcm947189acdbmr.dtb
>> -dtb-$(CONFIG_ARCH_BCM_63XX) += \
>> -    bcm963138dvt.dtb
>>   dtb-$(CONFIG_ARCH_BCM_CYGNUS) += \
>>       bcm911360_entphn.dtb \
>>       bcm911360k.dtb \
>> @@ -184,6 +182,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
>>       bcm7445-bcm97445svmb.dtb
>>   dtb-$(CONFIG_ARCH_BCMBCA) += \
>>       bcm947622.dtb \
>> +    bcm963138dvt.dtb \
>>       bcm963148.dtb \
>>       bcm963178.dtb \
>>       bcm96756.dtb \
> 
> Do we want to mix all that DT files? Are ARCH_BCM_63XX (ex-)users
> interested in compiling all of them?
> 
> For IPROC SoCs we have separated symbols: ARCH_BCM_CYGNUS / ARCH_BCM_HR2
> / ARCH_BCM_NSP / ARCH_BCM_5301X and we compile arch specific DT files
> only.

I am fine with that and build systems (buildroot and OpenWrt at least) 
typically offer a way to produce a device specific image that will 
contain a single DTB fit for the target device.

What we would be optimizing for would be build time vs. coverage, as a 
maintainer I favor coverage as it allows me to build everyone in one 
sweep. We could make the building of the 63138 conditional upon 
BCMBCA_CORTEXA9 if that bothers you.
-- 
Florian