linux-kernel - Re: [PATCH v2 1/1] virt: acrn: Mark the uuid field as unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ys7++n8ZsmTY6J6s@smile.fi.intel.com>
Date:   Wed, 13 Jul 2022 20:20:58 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Fei Li <fei1.li@...el.com>, Shuo Liu <shuo.a.liu@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] virt: acrn: Mark the uuid field as unused

On Wed, Jul 13, 2022 at 07:10:18PM +0200, Rafael J. Wysocki wrote:
> On Wed, Jul 13, 2022 at 7:03 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > After the commits for userspace [1][2] the uuid field is not being
> > used in the ACRN code. Update kernel to reflect these changes.
> > I.e. we do the following:
> > - adding a comment explaining that it's not used anymore
> > - replacing the specific type by a raw buffer
> > - updating the example code accordingly
> >
> > [1]: https://github.com/projectacrn/acrn-hypervisor/commit/da0d24326ed6
> > [2]: https://github.com/projectacrn/acrn-hypervisor/commit/bb0327e70097
> 
> Why don't you use a Link tag for each of these?

I can use Link tags.

> > Fixes: 5b06931d7f8b ("sample/acrn: Introduce a sample of HSM ioctl interface usage")
> > Fixes: 9c5137aedd11 ("virt: acrn: Introduce VM management interfaces")
> 
> Typically, the changelog should explain what was wrong in a previous
> commit that is being fixed in the current one, but that information is
> missing here.

The advertised field confused users and actually never been used. So
the wrong part here is that kernel puts something which userspace
never used and hence this may confuse a reader of this code.

Would it be sufficient? Another way is to drop Fixes tag.

-- 
With Best Regards,
Andy Shevchenko