linux-kernel - Re: [PATCH v5 2/5] drivers: thermal: tsens: Add support for combined interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Jul 2022 15:59:18 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Robert Marko <robimarko@...il.com>
Cc:     agross@...nel.org, konrad.dybcio@...ainline.org, amitk@...nel.org,
        thara.gopinath@...il.com, rafael@...nel.org,
        daniel.lezcano@...aro.org, rui.zhang@...el.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/5] drivers: thermal: tsens: Add support for combined
 interrupt

On Fri 08 Jul 08:29 CDT 2022, Robert Marko wrote:
[..]
> +static irqreturn_t tsens_combined_irq_thread(int irq, void *data)
> +{
> +	irqreturn_t ret;
> +
> +	ret = tsens_critical_irq_thread(irq, data);

Perhaps you could do something with this return value?

> +	ret = tsens_irq_thread(irq, data);

As written here, return tsens_irq_thread() seems cleaner.

Regards,
Bjorn