linux-kernel - Re: [PATCH net-next] net: lantiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220713142433.131e5a26@kernel.org>
Date:   Wed, 13 Jul 2022 14:24:33 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Aleksander Bajkowski <olek2@...pl>
Cc:     Eric Dumazet <edumazet@...gle.com>, hauke@...ke-m.de,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: lantiq_xrx200: use skb cache

On Wed, 13 Jul 2022 22:38:37 +0200 Aleksander Bajkowski wrote:
> > If you are changing this code path, what about adding proper error recovery ?
> > 
> > skb can be NULL at this point :/
>
> Good catch. I will try to test the fix on the device tomorrow and send the patch.

Let's defer this patch until we merge the fix, otherwise we'll get 
a conflict. Not a big deal but easily avoidable here.