linux-kernel - Re: [PATCH] net/mlx5e: Removed useless code in function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220713222638.nej53m5owfkr6dzz@sx1>
Date:   Wed, 13 Jul 2022 15:26:38 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Rustam Subkhankulov <subkhankulov@...ras.ru>
Cc:     Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maor Gottlieb <maorg@...lanox.com>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>
Subject: Re: [PATCH] net/mlx5e: Removed useless code in function

On 11 Jul 12:33, Rustam Subkhankulov wrote:
>Comparison of eth_ft->ft with NULL is useless, because
>get_flow_table() returns either pointer 'eth_ft'
>such that eth_ft->ft != NULL, or an erroneous value that is
>handled on return, causing mlx5e_ethtool_flow_replace()
>to terminate before checking whether eth_ft->ft equals NULL.
>
>Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
>Signed-off-by: Rustam Subkhankulov <subkhankulov@...ras.ru>
>Fixes: 6dc6071cfcde ("net/mlx5e: Add ethtool flow steering support")

Applied to net-next-mlx5 and removed the fixes tag. Since there is no bug
here.

Thanks,
Saeed.