linux-kernel - Re: [PATCH] USB: serial: cypress_m8: drop unexpected word "the" in the comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ys5prITWZSfLcZjp@hovoldconsulting.com>
Date:   Wed, 13 Jul 2022 08:43:56 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: cypress_m8: drop unexpected word "the" in
 the comments

On Wed, Jun 22, 2022 at 06:46:08PM +0800, Jiang Jian wrote:
> there is an unexpected word "the" in the comments that need to be dropped
> 
> file: drivers/usb/serial/cypress_m8.c
> line: 259
> 
>      * chose to use the the general purpose firmware or not), if you
> changed to:
>      * chose to use the general purpose firmware or not), if you
> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>  drivers/usb/serial/cypress_m8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
> index 6924fa95f6bd..da8913683104 100644
> --- a/drivers/usb/serial/cypress_m8.c
> +++ b/drivers/usb/serial/cypress_m8.c
> @@ -256,7 +256,7 @@ static int analyze_baud_rate(struct usb_serial_port *port, speed_t new_rate)
>  		/*
>  		 * Mike Isely <isely@...ox.com> 2-Feb-2008: The
>  		 * Cypress app note that describes this mechanism
> -		 * states the the low-speed part can't handle more
> +		 * states the low-speed part can't handle more

I believe the first "the" should be replaced with "that" here.

>  		 * than 800 bytes/sec, in which case 4800 baud is the
>  		 * safest speed for a part like that.
>  		 */

I've fixed up the above, merged this patch with the other one for
mos7720 and amended the commit message.

The result can be found here:

	https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next

Johan