linux-kernel - Re: [PATCH 0/4] Add Samsung system manager and secure service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3190164d-dcdb-6dd8-37c8-e1bb1128ef56@kernel.org>
Date:   Wed, 13 Jul 2022 09:42:12 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     dj76.yang@...sung.com,
        "jesper.nilsson@...s.com" <jesper.nilsson@...s.com>,
        "lars.persson@...s.com" <lars.persson@...s.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>
Cc:     "javierm@...hat.com" <javierm@...hat.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "linux-arm-kernel@...s.com" <linux-arm-kernel@...s.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Moon-Ki Jun <moonki.jun@...sung.com>,
        Sang Min Kim <hypmean.kim@...sung.com>,
        Wangseok Lee <wangseok.lee@...sung.com>
Subject: Re: [PATCH 0/4] Add Samsung system manager and secure service

On 13/07/2022 06:51, Dongjin Yang wrote:
> Add Samsung System manager driver and Secure Service code.
> Samsung System manager is for SoCs produced by Samsung Foundry
> to provide system read/write request by System Manager API.
> Samsung Secure service is for SoCs produced by Samsung Foundry
> to provide secure monitor service using Trusted Foundations.
> 

1. You need to provide users of these drivers. For the
syscon-regmap-export driver (better name than manager which does not
manager anything), having a user would answer the question why such
weird driver is needed. Since there is no user and driver's behavior
breaks design choices, it has to be NAKed.

2. Thread your submissions properly. Git send email does it
automatically for you. You can use other tools, but then be sure your
patches are properly threaded. This patchset was not which makes review
more difficult than it should.

Best regards,
Krzysztof