linux-kernel - Re: [PATCH v4 2/2] pinctrl: ocelot: Fix pincfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Jul 2022 01:35:37 -0700
From:   Colin Foster <colin.foster@...advantage.com>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linus.walleij@...aro.org, alexandre.belloni@...tlin.com,
        kavyasree.kotagiri@...rochip.com, UNGLinuxDriver@...rochip.com,
        maxime.chevallier@...tlin.com, michael@...le.cc,
        andy.shevchenko@...il.com
Subject: Re: [PATCH v4 2/2] pinctrl: ocelot: Fix pincfg

On Tue, Jul 12, 2022 at 09:50:43PM +0200, Horatiu Vultur wrote:
> The blamed commit changed to use regmaps instead of __iomem. But it
> didn't update the register offsets to be at word offset, so it uses byte
> offset.
> Another issue with the same commit is that it has a limit of 32 registers
> which is incorrect. The sparx5 has 64 while lan966x has 77.
> 
> Fixes: 076d9e71bcf8 ("pinctrl: ocelot: convert pinctrl to regmap")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

Acked-by: Colin Foster <colin.foster@...advantage.com>