linux-kernel - Re: A patch series improving data quality of perf test for CoreSight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <524ce022-fbdb-418d-d924-a9c510f3a769@arm.com>
Date:   Wed, 13 Jul 2022 09:14:13 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     carsten.haitzler@...s.arm.com, linux-kernel@...r.kernel.org
Cc:     coresight@...ts.linaro.org, mathieu.poirier@...aro.org,
        mike.leach@...aro.org, leo.yan@...aro.org,
        linux-perf-users@...r.kernel.org, acme@...nel.org
Subject: Re: A patch series improving data quality of perf test for CoreSight

Hi Carsten


On 12/07/2022 14:57, carsten.haitzler@...s.arm.com wrote:
> This is a prelude to adding more tests to shell tests and in order to
> support putting those tests into subdirectories, I need to change the
> test code that scans/finds and runs them.

Please could you add versioning to your series and a changelog of what
changed from one version to the other ? That way, it is easier for the
reviewers to understand and spend their time effectively on the newer
changes.

If you are using git format-patch, you could use -v <N> for the version
number in all your patches.

e.g,

https://lkml.kernel.org/r/20220414064457.12052-1-mike.leach@linaro.org

nit on Subject: This could be:

perf: test: Add trace data quality tests for CoreSight

where "perf" is the linux subsystem you are targeting and
  "test" is the specific area you are contributing. That helps
the reviewers to filter the series in a mailing list with
hundreds of emails.

> 
> To support subdirs I have to recurse so it's time to refactor the code to
> allow this and centralize the shell script finding into one location and
> only one single scan that builds a list of all the found tests in memory
> instead of it being duplicated in 3 places.
> 
> This code also optimizes things like knowing the max width of desciption
> strings (as we can do that while we scan instead of a whole new pass
> of opening files). It also more cleanly filters scripts to see only
> *.sh files thus skipping random other files in directories like *~
> backup files, other random junk/data files that may appear and the
> scripts must be executable to make the cut (this ensures the script
> lib dir is not seen as scripts to run). This avoids perf test running
> previous older versions of test scripts that are editor backup files
> as well as skipping perf.data files that may appear and so on.
> 
> Signed-off-by: Carsten Haitzler <carsten.haitzler@....com>
> 

It is also a good idea to have the diffstat of the series in the cover 
letter to give the people an idea of where the changes are touching.

git format-patch automatically gives you this if you add --cover-letter
option.

Suzuki

>