linux-kernel - Re: [PATCH -next] scsi: ufs: ufs-mediatek: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3SA9zvVu0i1m0kqbemLd4WfTMGfpc8VwhsmJOBgZHvsA@mail.gmail.com>
Date:   Wed, 13 Jul 2022 10:48:14 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Ren Zhijie <renzhijie2@...wei.com>
Cc:     Arnd Bergmann <arnd@...db.de>, stanley.chu@...iatek.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Bart Van Assche <bvanassche@....org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC..." 
        <linux-mediatek@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Fix build error

On Wed, Jul 13, 2022 at 3:44 AM Ren Zhijie <renzhijie2@...wei.com> wrote:
> 在 2022/7/12 16:27, Arnd Bergmann 写道:
>
> Thanks for your suggestion.
>
> How does it to fix the implicit-function-declaration error?
>

I missed that part at first. I would say the #ifdef around the
declarations in the
header should be removed here, it serves no purpose, and it is safe to rely
on the compiler to perform dead code elimination so this does not lead to
a link error even if a dead function references another function that is not
reachable.

        Arnd