linux-kernel - Re: [PATCH] Revert "reset: microchip-sparx5: allow building as a module"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73dc6fcedebcae098751bd093fe2d028@walle.cc>
Date:   Wed, 13 Jul 2022 11:03:40 +0200
From:   Michael Walle <michael@...le.cc>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        Clément Léger <clement.leger@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
Subject: Re: [PATCH] Revert "reset: microchip-sparx5: allow building as a
 module"

[+ Claudiu, Kavyasree ]
Am 2022-07-13 10:40, schrieb Philipp Zabel:
> This reverts commit b6b9585876da018bdde2d5f15d206a689c0d70f3.
> 
> This breaks MDIO on kswitch-d10, presumably because the global switch
> reset is not released early enough anymore.
> 
> Reported-by: Michael Walle <michael@...le.cc>
> Cc: Clément Léger <clement.leger@...tlin.com>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>

Thanks!

Tested-by: Michael Walle <michael@...le.cc>

And maybe Microchip can chime in here and tell us what
subsystems in the SoC will actually be reset by this.
I fear this reset will affect almost every part of the
SoC. So it would have to be bound to every single
device? Or maybe adding that reset to the switch driver
was a mistake in the first place?

I mean, if it wouldn't be for the guard bit, it would
also reset the CPU core..

-michael