linux-kernel - RE: [PATCH 1/2] lib/string_helpers: Introduce strsplit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17c91bfb3a864ae1be2ac3226f170f55@AcuMS.aculab.com>
Date:   Wed, 13 Jul 2022 09:14:09 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Cezary Rojewski' <cezary.rojewski@...el.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
CC:     Andy Shevchenko <andy@...nel.org>, Mark Brown <broonie@...nel.org>,
        "ALSA Development Mailing List" <alsa-devel@...a-project.org>,
        Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        "amadeuszx.slawinski@...ux.intel.com" 
        <amadeuszx.slawinski@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>
Subject: RE: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()

>          if (pint)
> -               *pint = value;
> +               memcpy(pint, &value, min(nsize, sizeof(value)));

That is just soooooo broken.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)