linux-kernel - Re: [PATCH] cpufreq: mediatek: Handle sram regulator probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220713112344.ye4xgjlqbhyvb46h@vireshk-i7>
Date:   Wed, 13 Jul 2022 16:53:44 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     rafael@...nel.org, lgirdwood@...il.com, broonie@...nel.org,
        matthias.bgg@...il.com, rex-bc.chen@...iatek.com,
        jia-wei.chang@...iatek.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] cpufreq: mediatek: Handle sram regulator probe deferral

On 13-07-22, 13:15, AngeloGioacchino Del Regno wrote:
> If the regulator_get_optional() call for the SRAM regulator returns
> a probe deferral, we must bail out and retry probing later: failing
> to do this will produce unstabilities on platforms requiring the
> handling for this regulator.
> 
> Fixes: ffa7bdf7f344 ("cpufreq: mediatek: Make sram regulator optional")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  drivers/cpufreq/mediatek-cpufreq.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index 3a2be4552020..7f2680bc9a0f 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -439,9 +439,13 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
>  
>  	/* Both presence and absence of sram regulator are valid cases. */
>  	info->sram_reg = regulator_get_optional(cpu_dev, "sram");
> -	if (IS_ERR(info->sram_reg))
> +	if (IS_ERR(info->sram_reg)) {
> +		ret = PTR_ERR(info->sram_reg);
> +		if (ret == -EPROBE_DEFER)
> +			goto out_free_resources;
> +
>  		info->sram_reg = NULL;
> -	else {
> +	} else {
>  		ret = regulator_enable(info->sram_reg);
>  		if (ret) {
>  			dev_warn(cpu_dev, "cpu%d: failed to enable vsram\n", cpu);

Applied. Thanks.

-- 
viresh