linux-kernel - Re: [PATCH 3/7] pwm: dwc: add of/platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Jul 2022 15:52:30 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Ben Dooks <ben.dooks@...ive.com>
Cc:     Rob Herring <robh@...nel.org>, linux-pwm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Greentime Hu <greentime.hu@...ive.com>,
        Jude Onyenegecha <jude.onyenegecha@...ive.com>,
        Sudip Mukherjee <sudip.mukherjee@...ive.com>,
        William Salmon <william.salmon@...ive.com>,
        Adnan Chowdhury <adnan.chowdhury@...ive.com>
Subject: Re: [PATCH 3/7] pwm: dwc: add of/platform support

On Wed, Jul 13, 2022 at 12:56:55PM +0100, Ben Dooks wrote:
> On 12/07/2022 23:17, Rob Herring wrote:
> > On Tue, Jul 12, 2022 at 11:01:09AM +0100, Ben Dooks wrote:
> > > The dwc pwm controller can be used in non-PCI systems, so allow
> > > either platform or OF based probing.
> > > 
> > > Signed-off-by: Ben Dooks <ben.dooks@...ive.com>
> > > ---
> > >   .../devicetree/bindings/pwm/pwm-synposys.yaml | 40 ++++++++++++++
> > 
> > Use compatible string for filename.
> 
> ok, will fix.
> 
> > >   drivers/pwm/Kconfig                           |  5 +-
> > >   drivers/pwm/pwm-dwc.c                         | 53 +++++++++++++++++++
> > >   3 files changed, 96 insertions(+), 2 deletions(-)
> > >   create mode 100644 Documentation/devicetree/bindings/pwm/pwm-synposys.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-synposys.yaml b/Documentation/devicetree/bindings/pwm/pwm-synposys.yaml
> > > new file mode 100644
> > > index 000000000000..38ac0da75272
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/pwm/pwm-synposys.yaml
> > > @@ -0,0 +1,40 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +# Copyright (C) 2022 SiFive, Inc.
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/pwm/pwm-synposys.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Synopsys PWM controller
> > > +
> > > +maintainers:
> > > +   - Ben Dooks <ben.dooks@...ive.com>
> > > +
> > > +properties:
> > > +  "#pwm-cells":
> > > +    description: |
> > > +      See pwm.yaml in this directory for a description of the cells format.
> > 
> > pwm.yaml doesn't define how many cells. You need to. And you don't need
> > generic descriptions.
> 
>  "#pwm-cells":
>     const: 1
> 
> should be sufficient then?

I would expect a value of (at least) 2 or (better) 3.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)