linux-kernel - Re: [PATCH -next] writeback: Cleanup bdi_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220713140308.5je2p3zz4vm4fvjb@quack3>
Date:   Wed, 13 Jul 2022 16:03:08 +0200
From:   Jan Kara <jack@...e.cz>
To:     Xiu Jianfeng <xiujianfeng@...wei.com>
Cc:     akpm@...ux-foundation.org, axboe@...nel.dk, neilb@...e.de,
        johannes.thumshirn@....com, jack@...e.cz, willy@...radead.org,
        mgorman@...hsingularity.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()

On Wed 13-07-22 20:53:14, Xiu Jianfeng wrote:
> bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
> replace custom worker pool implementation with unbound workqueue"),
> so remove it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/backing-dev.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..e84b745a6811 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -140,12 +140,6 @@ static inline bool mapping_can_writeback(struct address_space *mapping)
>  	return inode_to_bdi(mapping->host)->capabilities & BDI_CAP_WRITEBACK;
>  }
>  
> -static inline int bdi_sched_wait(void *word)
> -{
> -	schedule();
> -	return 0;
> -}
> -
>  #ifdef CONFIG_CGROUP_WRITEBACK
>  
>  struct bdi_writeback *wb_get_lookup(struct backing_dev_info *bdi,
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR