linux-kernel - Re: [PATCH v4 2/4] dt-bindings: regulator: add bindings for output-supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220714141041.GB2229197-robh@kernel.org>
Date:   Thu, 14 Jul 2022 08:10:41 -0600
From:   Rob Herring <robh@...nel.org>
To:     Naresh Solanki <naresh.solanki@...ements.com>
Cc:     linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Patrick Rudolph <patrick.rudolph@...ements.com>
Subject: Re: [PATCH v4 2/4] dt-bindings: regulator: add bindings for
 output-supply

On Thu, Jul 07, 2022 at 10:18:24AM +0200, Naresh Solanki wrote:
> Add a devicetree binding for the 9elements,output-supply driver.

Bindings are for h/w, not drivers.

> Example is also provided.
> 
> Signed-off-by: Naresh Solanki <Naresh.Solanki@...ements.com>
> ---
>  .../regulator/9elements,output-supply.yaml    | 63 +++++++++++++++++++
>  1 file changed, 63 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/9elements,output-supply.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/9elements,output-supply.yaml b/Documentation/devicetree/bindings/regulator/9elements,output-supply.yaml
> new file mode 100644
> index 000000000000..e4b67bc0794f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/9elements,output-supply.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/userspace-consumer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Regulator output-supply driver
> +
> +maintainers:
> +  - Patrick Rudolph <patrick.rudolph@...ements.com>
> +
> +description: |
> +  Regulator output-supply driver helps interact with regulator.
> +  Provides regulator events & sysfs notify to capture regulator events
> +  in realtime for userspace application.
> +  This enables userspace application to monitor events in regulator(s) &
> +  handle them appropriately.

What does userspace have to do with hardware description?

> +
> +
> +properties:
> +  compatible:
> +    enum:
> +      - 9elements,output-supply

Why does this have a vendor prefix when it appears to be a s/w 
construct?

> +
> +  regulator-name:
> +    description: Name of the consumer line
> +
> +  regulator-boot-on:
> +    description: Enable regulator during boot
> +
> +  regulator-supplies:
> +    description: Supply names for this regulator. This can be multiple strings

What's the type for this? 

The supply names are the prefix on -supply properties.

> +
> +patternProperties:
> +  ".*-supply$":
> +    description: |
> +      Input supply phandle(s) for this node. There should be
> +      <supply-name>-supply to pass regulators handle
> +
> +required:
> +  - compatible
> +  - regulator-supplies
> +  - ".*-supply$"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    p12v_b_consumer {
> +        compatible = "9elements,output-supply";
> +        regulator-name = "BCM1";
> +        regulator-supplies = "vbus";
> +        vbus-supply = <&p12v_b>;
> +    };
> +
> +    ssb_rssd32 {
> +        compatible = "9elements,output-supply";
> +        regulator-name = "ssb_rssd32";
> +        regulator-supplies = "sw0", "sw1";
> +        sw0-supply = <&sw0_ssb_rssd32>;
> +        sw1-supply = <&sw1_ssb_rssd32>;
> +    };
> +...
> -- 
> 2.35.3
> 
>