linux-kernel - Re: [PATCH v13 2/2] KVM: s390: resetting the Topology-Change-Report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 16:12:00 +0200
From:   Janosch Frank <frankja@...ux.ibm.com>
To:     Pierre Morel <pmorel@...ux.ibm.com>, kvm@...r.kernel.org
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        borntraeger@...ibm.com, cohuck@...hat.com, david@...hat.com,
        thuth@...hat.com, imbrenda@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, wintera@...ux.ibm.com, seiden@...ux.ibm.com,
        nrb@...ux.ibm.com, scgl@...ux.ibm.com
Subject: Re: [PATCH v13 2/2] KVM: s390: resetting the Topology-Change-Report

On 7/14/22 12:18, Pierre Morel wrote:
> During a subsystem reset the Topology-Change-Report is cleared.
> 
> Let's give userland the possibility to clear the MTCR in the case
> of a subsystem reset.
> 
> To migrate the MTCR, we give userland the possibility to
> query the MTCR state.
> 
> We indicate KVM support for the CPU topology facility with a new
> KVM capability: KVM_CAP_S390_CPU_TOPOLOGY.
> 
> Signed-off-by: Pierre Morel <pmorel@...ux.ibm.com>
> Reviewed-by: Janis Schoetterl-Glausch <scgl@...ux.ibm.com>

Nit below, but:
Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>

> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -1158,6 +1158,7 @@ struct kvm_ppc_resize_hpt {
>   #define KVM_CAP_SYSTEM_EVENT_DATA 215
>   #define KVM_CAP_ARM_SYSTEM_SUSPEND 216
>   #define KVM_CAP_S390_PROTECTED_DUMP 217
> +#define KVM_CAP_S390_CPU_TOPOLOGY 218
>   #define KVM_CAP_S390_ZPCI_OP 221

Using 222 and moving it a line down might make more sense as 218 is 
KVM_CAP_X86_TRIPLE_FAULT_EVENT.

Can you fix this and push both patches to devel?
Also send the fixed patch as a reply to this message so I can pick it 
from the list.

next and devel have diverted a bit so I will need to fix this up for 
next, same for the Documentation entry which will be 6.39 instead of 6.38.

>   
>   #ifdef KVM_CAP_IRQ_ROUTING