linux-kernel - Re: [PATCH v2 5/5] arm64: dts: qcom: Add device tree for Sony Xperia 1 IV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220714141545.2z65355wgjuqeuwl@SoMainline.org>
Date:   Thu, 14 Jul 2022 16:15:45 +0200
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     Konrad Dybcio <konrad.dybcio@...ainline.org>,
        ~postmarketos/upstreaming@...ts.sr.ht, martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        jamipkettunen@...ainline.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: Add device tree for Sony Xperia
 1 IV

On 2022-07-14 14:51:36, AngeloGioacchino Del Regno wrote:
[..]
> > +&i2c14 {
> > +	clock-frequency = <1000000>;
> > +	status = "okay";
> > +
> > +	cs35l41_l: speaker-amp@40 {
> 
> What about an even more generic audio-amplifier@40 ?

If I understood Krzystof's comment correctly the "generic name" request
is to describe in human terms what kind of device this is and perhaps
what it is used for.  Since it is specifically driving a physical
speaker on this phone, carrying the word "speaker" in the name is better
than "audio", IMO.

I'm indifferent as to whether amp is written out as amplifier.

- Marijn

> > +		compatible = "cirrus,cs35l41";
> > +		reg = <0x40>;
> > +		interrupt-parent = <&tlmm>;
> > +		interrupts = <182 IRQ_TYPE_LEVEL_LOW>;
> > +		reset-gpios = <&tlmm 183 GPIO_ACTIVE_HIGH>;
> > +		cirrus,boost-peak-milliamp = <4000>;
> > +		cirrus,boost-ind-nanohenry = <1000>;
> > +		cirrus,boost-cap-microfarad = <15>;
> > +		cirrus,gpio2-src-select = <2>;
> > +		cirrus,gpio2-output-enable;
> > +		cirrus,asp-sdout-hiz = <3>;
> > +		#sound-dai-cells = <1>;
> > +	};
> > +
> > +	cs35l41_r: speaker-amp@41 {
> > +		compatible = "cirrus,cs35l41";
> > +		reg = <0x41>;
> > +		interrupt-parent = <&tlmm>;
> > +		interrupts = <182 IRQ_TYPE_LEVEL_LOW>;
> > +		reset-gpios = <&tlmm 183 GPIO_ACTIVE_HIGH>;
> > +		cirrus,boost-peak-milliamp = <4000>;
> > +		cirrus,boost-ind-nanohenry = <1000>;
> > +		cirrus,boost-cap-microfarad = <15>;
> > +		cirrus,gpio2-src-select = <2>;
> > +		cirrus,gpio2-output-enable;
> > +		cirrus,asp-sdout-hiz = <3>;
> > +		#sound-dai-cells = <1>;
> > +	};
> > +};
> > +