linux-kernel - Re: [PATCH v4 2/3] arm64: dts: qcom: Add sc7280-herobrine-villager-r1.dts file for LTE sku in sc7280-villager family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 07:58:02 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Jimmy Chen <jinghung.chen3@...mail.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        Alan Huang <alan-huang@...nta.corp-partner.google.com>,
        Rob Herring <robh+dt@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: Add sc7280-herobrine-villager-r1.dts
 file for LTE sku in sc7280-villager family

Hi,

On Thu, Jul 14, 2022 at 12:50 AM Jimmy Chen <jinghung.chen3@...mail.com> wrote:
>
> This adds sc7280-herobrine-villager-r1.dts for villager device tree files.

You could mention why -r1 is different. It would be enough to say
something like:

Herobrine-r1 is exactly the same as -r0 except that it uses a
different audio solution (it uses the same one as the CRD).


> Signed-off-by: Jimmy Chen <jinghung.chen3@...mail.com>
>
> ---
>
> Changes in v4:
> -Add this patch
>
>  .../boot/dts/qcom/sc7280-herobrine-villager-r1.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts

The ${SUBJECT} of this patch is a bit long and seems like it could be
shortened. Unless it's unavoidable I try to keep mine under 80
characters. How about just:

arm64: dts: qcom: sc7280: Add herobrine-villager-r1


> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> new file mode 100644
> index 0000000000000..c03b3ae4de506
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> @@ -0,0 +1,14 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Villager board device tree source
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +#include "sc7280-herobrine-villager-r0.dts"
> +#include "sc7280-herobrine-audio-wcd9385.dtsi"
> +
> +/ {
> +       model = "Google Villager (rev1+)";
> +       compatible = "google,villager", "qcom,sc7280";
> +};

You should also add the -r1 dts to the Makefile in this patch.

Also as part of this patch you should change the
"sc7280-herobrine-villager-r0.dts" so that it isn't "rev0+" but is
just "rev0", AKA:

-       model = "Google Villager (rev0+)";
-       compatible = "google,villager", "qcom,sc7280";
+       model = "Google Villager (rev0)";
+       compatible = "google,villager-rev0", "qcom,sc7280";