linux-kernel - Re: [PATCH v3] lib/bitmap: Make count and length parameters unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 19:47:31 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     Yury Norov <yury.norov@...il.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] lib/bitmap: Make count and length parameters unsigned

On Thu, Jul 14, 2022 at 06:42:07PM +0200, Paul Menzel wrote:
> Counts and the length are non-negative, so make them unsigned, and adapt the
> while condition in `__bitmap_set()` and `__bitmap_clear()` accordingly.
> 
> For `__bitmap_set()` six less intstructions are used as a result:

You may check this by doing

	make allyesconfig
	make
	cp vmlinux.o old
	# apply your patch
	make
	cp vmlinux.o new
	scripts/bloat-o-meter old new

-- 
With Best Regards,
Andy Shevchenko