linux-kernel - Re: [PATCH] firmware_loader: Replace kmap() with kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtB/QJw84z7mh0dr@bombadil.infradead.org>
Date:   Thu, 14 Jul 2022 13:40:32 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Russ Weight <russell.h.weight@...el.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Nick Terrell <terrelln@...com>, linux-kernel@...r.kernel.org,
        Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH] firmware_loader: Replace kmap() with kmap_local_page()

On Thu, Jul 14, 2022 at 04:50:42PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 11, 2022 at 08:52:49PM +0200, Fabio M. De Francesco wrote:
> > 
> > I see that the outputs of selftests, regardless of running a 5.19.0-rc6  
> > kernel with or without my changes, show always the same error:
> > 
> > "not ok 1 selftests: firmware: fw_run_tests.sh # TIMEOUT 165 seconds".".
> > 
> > I ran those tests on a QEMU/KVM 32-bits VM, booting a vanilla 5.19.0-rc6 
> > kernel with HIGHMEM64GB enabled. 
> > 
> > As said, outputs don't change with or without my patch. Instead it changes 
> > with the latest openSUSE stock kernel (5.18.9-2-pae):
> > 
> > "ok 1 selftests: firmware: fw_run_tests.sh".
> > 
> > Unfortunately, I'm not familiar with kernel selftests. Any ideas about what 
> > could have made this tests fail? Is it expected? 
> > 
> > If not, I can try and figure out why these outputs are not what they should 
> > be (the second version of my patch can wait the time it takes).
> 
> No idea, sorry, Luis might know more.

The selftests should have a config file, ensure that stuff is all
enabled. Can you verify if this stuff was enabled on your config:

cat tools/testing/selftests/firmware/config 
CONFIG_TEST_FIRMWARE=y
CONFIG_FW_LOADER=y
CONFIG_FW_LOADER_USER_HELPER=y
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
CONFIG_FW_UPLOAD=y

  Luis