linux-kernel - Re: [PATCH v2 00/10] lib: cleanup bitmap-related headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 15:15:20 -0700
From:   Yury Norov <yury.norov@...il.com>
To:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        David Howells <dhowells@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Jonathan Corbet <corbet@....net>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        NeilBrown <neilb@...e.de>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Russell King <linux@...linux.org.uk>,
        Vlastimil Babka <vbabka@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>,
        linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mm@...ck.org
Subject: Re: [PATCH v2 00/10] lib: cleanup bitmap-related headers

On Tue, Jul 12, 2022 at 09:28:21AM -0700, Yury Norov wrote:
> On Wed, Jul 6, 2022 at 10:42 AM Yury Norov <yury.norov@...il.com> wrote:
> >
> > This series unifies declarations of bitmap-related functions and aligns
> > return types with values that actually returned. Also, it moves one-liner
> > wrappers around cpumask functions into headers, so that compiler has a
> > chance to optimize better.
> >
> > With this series, GCC 11.2 for ARM64 with kernel v5.19-rc4:
> > add/remove: 15/7 grow/shrink: 461/164 up/down: 14844/-4580 (10264)
> >
> > This +10K didn't surprise me because  modern compilers are more aggressive
> > in inlining, loop unrolling, and other techniques that increase size of
> > the image.
> >
> > v1: https://lore.kernel.org/linux-mm/YsAzU3g2QpgmIGre@smile.fi.intel.com/T/
> > v2: - Align whitespaces in headers;
> >     - Make bitmap_weight() unsigned long consistently;
> >     - Pick 2 patches from Ingo's sched/headers series [1] that split
> >       linux/gfp.h, and drop my similar patch for it.
> 
> Ping?

OK, I realize that it's not the very entertaining thing to review a
headers cleanup.

Adding this into -next because there's no negative feedback (he-he).