lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jul 2022 13:37:31 +0800 From: Biao Huang <biao.huang@...iatek.com> To: Jakub Kicinski <kuba@...nel.org> CC: David Miller <davem@...emloft.net>, Matthias Brugger <matthias.bgg@...il.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, <netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>, <macpaul.lin@...iatek.com>, "Jisheng Zhang" <jszhang@...nel.org>, Mohammad Athari Bin Ismail <mohammad.athari.ismail@...el.com> Subject: Re: [PATCH net v4 3/3] net: stmmac: fix unbalanced ptp clock issue in suspend/resume flow Dear Jakub, Thanks for your comments~ On Wed, 2022-07-13 at 20:39 -0700, Jakub Kicinski wrote: > On Wed, 13 Jul 2022 18:10:02 +0800 Biao Huang wrote: > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > index 197fac587ad5..c230b8b9aab1 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > @@ -839,14 +839,6 @@ int stmmac_init_tstamp_counter(struct > > stmmac_priv *priv, u32 systime_flags) > > if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)) > > return -EOPNOTSUPP; > > > > - ret = clk_prepare_enable(priv->plat->clk_ptp_ref); > > - if (ret < 0) { > > - netdev_warn(priv->dev, > > - "failed to enable PTP reference clock: > > %pe\n", > > - ERR_PTR(ret)); > > - return ret; > > - } > > - > > stmmac_config_hw_tstamping(priv, priv->ptpaddr, systime_flags); > > priv->systime_flags = systime_flags; > > > > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:837:6: warning: > unused variable 'ret' [-Wunused-variable] > int ret; > ^ OK, I'll fix it in next send. Best Regards! Biao
Powered by blists - more mailing lists