linux-kernel - Re: [PATCH v18 1/2] dt-bindings: usb: Add analogix anx7411 PD binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3c98e31-7c68-34a6-f492-95c1b6eeb625@linaro.org>
Date:   Thu, 14 Jul 2022 08:52:09 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Xin Ji <xji@...logixsemi.com>
Cc:     bliang@...logixsemi.com, qwen@...logixsemi.com,
        jli@...logixsemi.com, Rob Herring <robh@...nel.org>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v18 1/2] dt-bindings: usb: Add analogix anx7411 PD binding

On 14/07/2022 04:02, Xin Ji wrote:
> On Wed, Jul 13, 2022 at 11:28:16AM +0200, Krzysztof Kozlowski wrote:
>> On 13/07/2022 10:41, Xin Ji wrote:
>>> Add analogix PD chip anx7411 device binding
>>>
>>> Reviewed-by: Rob Herring <robh@...nel.org>
>>> Signed-off-by: Xin Ji <xji@...logixsemi.com>
>>>
>>> ---
>>> v17 -> v18 : Change node name from "usb_typec" to "typec"
>>
>> Node name was anx7411, not usb_typec. What are you changing here? The label?
> Hi Krzysztof, sorry, I'm confused by your comment, this patch followed the
> other dts example in other yaml file and passed the dts checking by
> command "make dt_binding_check".
> 
> Do you mean change the the node name "anx7411" to "typec"?

Yes, since the some revisions ago I asked to use a generic name for the
node (generic node name).


Best regards,
Krzysztof