linux-kernel - Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a4fba17-9c71-a4e6-643a-62aa0dfd4774@linaro.org>
Date:   Thu, 14 Jul 2022 08:56:12 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Pali Rohár <pali@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada
 3720 boards

On 13/07/2022 22:03, Pali Rohár wrote:
> On Wednesday 13 July 2022 21:42:43 Krzysztof Kozlowski wrote:
>> On 13/07/2022 14:56, Pali Rohár wrote:
>>> All Armada 3720 boards have Armada 3720 processor which is of Armada 3700
>>> family and do not have Armada 3710 processor. So none of them should have
>>> compatible string for Armada 3710 processor.
>>>
>>> Fix compatible string for all these boards by removing wrong processor
>>> string "marvell,armada3710" and adding family string "marvell,armada3700"
>>> as the last one. (Note that this is same way how are defined Armada 3710
>>> DTS files).
>>
>> Please do not introduce some changes just in DTS, but start from the
>> bindings. Someone wrote the bindings like that and expected to be that
>> way, so first change the bindings with proper rationale. Then change the
>> DTS files.
>>
>>
>> Best regards,
>> Krzysztof
> 
> Ok, I tried to update bindings and fix example in it, see patch:
> https://lore.kernel.org/linux-devicetree/20220713200123.22612-1-pali@kernel.org/

The reason you used here should be expressed in that commit as well
because you change the ABI and affect other users (projects, systems).

Best regards,
Krzysztof