linux-kernel - Re: [PATCH] ALSA: usb-audio: Use atomic_try_cmpxchg in ep_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wncgw02l.wl-tiwai@suse.de>
Date:   Thu, 14 Jul 2022 10:49:38 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Uros Bizjak <ubizjak@...il.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Use atomic_try_cmpxchg in ep_state_update

On Wed, 13 Jul 2022 17:19:46 +0200,
Uros Bizjak wrote:
> 
> Use atomic_try_cmpxchg instead of atomic_cmpxchg (*ptr, old, new) == old in
> ep_state_update. x86 CMPXCHG instruction returns success in ZF flag,
> so this change saves a compare after cmpxchg (and related move instruction
> in front of cmpxchg).
> 
> No functional change intended.
> 
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Cc: Takashi Iwai <tiwai@...e.de>

Thanks, applied.


Takashi