linux-kernel - Re: [PATCH -next] writeback: Cleanup inode_to_wb_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220714101207.5qh3bfvadqrorerp@quack3>
Date:   Thu, 14 Jul 2022 12:12:07 +0200
From:   Jan Kara <jack@...e.cz>
To:     Xiu Jianfeng <xiujianfeng@...wei.com>
Cc:     akpm@...ux-foundation.org, axboe@...nel.dk, neilb@...e.de,
        johannes.thumshirn@....com, jack@...e.cz, willy@...radead.org,
        mgorman@...hsingularity.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] writeback: Cleanup inode_to_wb_is_valid()

On Thu 14-07-22 16:41:47, Xiu Jianfeng wrote:
> inode_to_wb_is_valid() is no longer used since commit fe55d563d417
> ("remove inode_congested()"), remove it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Looks good! Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/backing-dev.h | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..f9f14e385582 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -235,18 +235,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
>  	return wb;
>  }
>  
> -/**
> - * inode_to_wb_is_valid - test whether an inode has a wb associated
> - * @inode: inode of interest
> - *
> - * Returns %true if @inode has a wb associated.  May be called without any
> - * locking.
> - */
> -static inline bool inode_to_wb_is_valid(struct inode *inode)
> -{
> -	return inode->i_wb;
> -}
> -
>  /**
>   * inode_to_wb - determine the wb of an inode
>   * @inode: inode of interest
> @@ -345,11 +333,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
>  	return &bdi->wb;
>  }
>  
> -static inline bool inode_to_wb_is_valid(struct inode *inode)
> -{
> -	return true;
> -}
> -
>  static inline struct bdi_writeback *inode_to_wb(struct inode *inode)
>  {
>  	return &inode_to_bdi(inode)->wb;
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR